Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toktok fix patch #31

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Toktok fix patch #31

merged 1 commit into from
Jun 27, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Jun 27, 2019

Fix toktok for Stanford Sentiment Treebank as reported in JuliaText/CorpusLoaders.jl#18

@Ayushk4 Ayushk4 force-pushed the toktok_fix_patch branch from 17817a3 to 34d5e2c Compare June 27, 2019 13:19
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should now have merge permissions so merge when ready

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #31 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   94.27%   94.28%   +0.01%     
==========================================
  Files          10       10              
  Lines         524      525       +1     
==========================================
+ Hits          494      495       +1     
  Misses         30       30
Impacted Files Coverage Δ
src/words/TokTok.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc1220...34d5e2c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #31 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   94.27%   94.28%   +0.01%     
==========================================
  Files          10       10              
  Lines         524      525       +1     
==========================================
+ Hits          494      495       +1     
  Misses         30       30
Impacted Files Coverage Δ
src/words/TokTok.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc1220...34d5e2c. Read the comment docs.

@Ayushk4 Ayushk4 merged commit 73e7d71 into JuliaText:master Jun 27, 2019
@Ayushk4
Copy link
Member Author

Ayushk4 commented Jun 27, 2019

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants