Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper update #34

Merged
merged 5 commits into from
Aug 13, 2019
Merged

JOSS paper update #34

merged 5 commits into from
Aug 13, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Jul 2, 2019

I am opening this PR to JuliaText:josspaper.

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #34 into josspaper will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           josspaper      #34   +/-   ##
==========================================
  Coverage      95.74%   95.74%           
==========================================
  Files              5        5           
  Lines             94       94           
==========================================
  Hits              90       90           
  Misses             4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6086657...73a4b2d. Read the comment docs.

@Ayushk4
Copy link
Member Author

Ayushk4 commented Jul 5, 2019

@oxinabox Should I include a section on other software for natural language tokenization available to Julia users?

@oxinabox
Copy link
Member

oxinabox commented Jul 5, 2019

yes.
It should also mention TextAnalysis and CorpusLoaders as packages that use WordTokenizers.jl

@Ayushk4
Copy link
Member Author

Ayushk4 commented Jul 5, 2019

It is also being used by https://github.com/chengchingwen/Transformers.jl and BytePairEncoding.jl, should these two also be mentioned?

@Ayushk4
Copy link
Member Author

Ayushk4 commented Jul 10, 2019

@oxinabox Please review and give suggestions on this.

@Ayushk4
Copy link
Member Author

Ayushk4 commented Aug 13, 2019

@oxinabox could you review this PR?

@oxinabox oxinabox merged commit 8660579 into JuliaText:josspaper Aug 13, 2019
@oxinabox
Copy link
Member

Sorry, yes, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants