-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper update #34
Conversation
Codecov Report
@@ Coverage Diff @@
## josspaper #34 +/- ##
==========================================
Coverage 95.74% 95.74%
==========================================
Files 5 5
Lines 94 94
==========================================
Hits 90 90
Misses 4 4 Continue to review full report at Codecov.
|
@oxinabox Should I include a section on |
yes. |
It is also being used by https://github.com/chengchingwen/Transformers.jl and BytePairEncoding.jl, should these two also be mentioned? |
@oxinabox Please review and give suggestions on this. |
@oxinabox could you review this PR? |
Sorry, yes, LGTM |
I am opening this PR to JuliaText:josspaper.