Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot comparing speeds of tokenizers to JOSS paper. #36

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Aug 30, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #36 into josspaper will increase coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           josspaper      #36      +/-   ##
=============================================
+ Coverage      94.41%   95.74%   +1.33%     
=============================================
  Files             10        5       -5     
  Lines            555       94     -461     
=============================================
- Hits             524       90     -434     
+ Misses            31        4      -27
Impacted Files Coverage Δ
src/words/simple.jl 83.33% <0%> (-16.67%) ⬇️
src/words/sedbased.jl 100% <0%> (ø) ⬆️
src/words/tweet_tokenizer.jl
src/words/TokTok.jl
src/words/fast.jl
src/words/reversible_tokenize.jl
src/words/nltk_word.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8660579...e09ff0a. Read the comment docs.

@Ayushk4
Copy link
Member Author

Ayushk4 commented Aug 31, 2019

I have made the suggested changes. You may review.

@oxinabox oxinabox merged commit 53e5d1c into JuliaText:josspaper Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants