Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes in JOSS paper #40

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Minor Fixes in JOSS paper #40

merged 2 commits into from
Dec 9, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Dec 9, 2019

  • Added DOIs in paper.bib.
  • Fixed double brackets and spaces around the citations.
  • Removes extra " in the reference.

This is ready for review.

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          10       10           
  Lines         525      525           
=======================================
  Hits          494      494           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26ed45...7c44ada. Read the comment docs.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@oxinabox oxinabox merged commit 2c58e90 into JuliaText:master Dec 9, 2019
@Ayushk4 Ayushk4 deleted the doi_patch branch December 13, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants