Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a number of typos in paper and readme #41

Merged
merged 2 commits into from
Jan 19, 2020

Conversation

leios
Copy link
Contributor

@leios leios commented Jan 18, 2020

This is part of an overall review for the Journal of Open Source Software. Note that these edits are suggestions, don't feel obliged to use them.

@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          10       10           
  Lines         525      525           
=======================================
  Hits          494      494           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c58e90...5d4662a. Read the comment docs.

Copy link
Member

@Ayushk4 Ayushk4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

Co-Authored-By: Lyndon White <oxinabox@ucc.asn.au>
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
thanks!

@oxinabox oxinabox merged commit 27da5ac into JuliaText:master Jan 19, 2020
@leios leios deleted the leios_review branch January 19, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants