Changed Compat.UTF8String to String (#13) #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to drop 0.4 support for this to be correct |
|
Oh, right. Is this a big deal? Any idea how many people are still using 0.4? |
|
I'd be happy to drop both 0.4 and 0.5 and require 0.6. People on earlier versions of Julia can still install the package, they'd just install an earlier version of it. |
|
I, obviously, second that. |
|
I'm sorry, this is only my second Julia PR. Is there anything else I should do, or how (if at all) is this going forward? |
|
I'm dropping support for earlier versions of Julia in #15. Once that's merged, this can be merged as-is, since it will be fully correct across all supported versions. |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to avoid deprecation warnings (see #13 ).