Allow passing in a custom boundary to HTTP.Form #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 76.24% 76.19% -0.06%
==========================================
Files 37 37
Lines 2269 2268 -1
==========================================
- Hits 1730 1728 -2
- Misses 539 540 +1
Continue to review full report at Codecov.
|
aviks
approved these changes
Nov 1, 2020
quinnj
reviewed
Nov 2, 2020
| @@ -53,9 +53,8 @@ function Base.read(f::Form, n::Integer) | |||
| return result | |||
| end | |||
|
|
|||
| function Form(d) | |||
| function Form(d; boundary=string(rand(UInt128), base=16)) | |||
There was a problem hiding this comment.
If we're allowing people to pass in a boundary, it might be helpful to assert they pass a string of the right length
There was a problem hiding this comment.
Good idea, I can open another PR in the morning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is also motivated by BrokenRecord. If you want your HTTP request body to be deterministic, you need to be able to set the multipart boundary yourself.