create Headers type that will safely and conviently deal with duplicates #20
Conversation
Unfortunately, HTTP can have duplicate headers, namely 'Set-Cookie'.
We could just store headers as Dict{String,Vector{String}}, but
that would push the pain onto everybody, where few are going to care.
By creating a 'Headers' type which impliments 'Associative' the users
can interact with headers as simply as if it were a
Dict{String,String}, but it's still safe for duplicate headers.
|
This looks like a good change, but perhaps it makes more sense to contribute a general purpose Associative type to JuliaLang/DataStructures.jl and then use it here for HTTP headers. |
|
Associative already exists and is an abstract type for things like Dict. But you're right, having a "multimap" type Dict could be useful for others, so I'll look into that |
|
@srp DataStructures.jl now contains a SortedMultidict type. Are you still interested in working on this PR, or shall I take it over (no pressure either way)? |
|
Awesome, I hadn't seen that! Feel free to work on it, I probably won't get On Thu, Aug 13, 2015 at 7:17 PM, Jonathan Malmaud notifications@github.com
|
|
I'm going to close this for now in favor of #24, which essentailly special-cases cookies. If repeated headers besides set-cookie are actually a real problem for your use case, please reopen and we can think of a solution. |
Unfortunately, HTTP can have duplicate headers, namely 'Set-Cookie'.
We could just store headers as Dict{String,Vector{String}}, but
that would push the pain onto everybody, where few are going to care.
By creating a 'Headers' type which impliments 'Associative' the users
can interact with headers as simply as if it were a
Dict{String,String}, but it's still safe for duplicate headers.