Skip to content

Fix ignore_warning with non-boolean arguments #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Fix ignore_warning with non-boolean arguments #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82ae89
Fix ignore_warning with non-boolean arguments
isometry Feb 12, 2020
c61084e
chnages to make sure odd value is not entertained
Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions ansible_collection/Juniper/junos/plugins/module_utils/juniper_junos_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,16 +1201,17 @@ def parse_ignore_warning_option(self):
if ignore_warn_list is None:
return ignore_warn_list
if len(ignore_warn_list) == 1:
bool_val = boolean(ignore_warn_list[0])
if bool_val is not None:
return bool_val
elif isinstance(ignore_warn_list[0], basestring):
return ignore_warn_list[0]
else:
self.fail_json(msg="The value of the ignore_warning option "
"(%s) is invalid. Unexpected type (%s)." %
(ignore_warn_list[0],
type(ignore_warn_list[0])))
try:
bool_val = boolean(ignore_warn_list[0])
if bool_val is not None:
return bool_val
except TypeError:
if isinstance(ignore_warn_list[0], basestring):
return ignore_warn_list[0]
self.fail_json(msg="The value of the ignore_warning option "
"(%s) is invalid. Unexpected type (%s)." %
(ignore_warn_list[0],
type(ignore_warn_list[0])))
elif len(ignore_warn_list) > 1:
for ignore_warn in ignore_warn_list:
if not isinstance(ignore_warn, basestring):
Expand Down