Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-13887] Modified jamf-crowdstrike widget query #121

Merged
merged 5 commits into from
Oct 24, 2023
Merged

[APP-13887] Modified jamf-crowdstrike widget query #121

merged 5 commits into from
Oct 24, 2023

Conversation

ahadrovic
Copy link
Contributor

@ahadrovic ahadrovic commented Oct 24, 2023 •
edited
Loading

QA Checklist

Insights

  • Does a related dashboard already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Make sure dashboard layout is correct, Save default layout and replace if not
  • Upload the dashboard JSON into JupiterOne to validate
  • Make sure there is a screenshot with no sensitive data
  • Update the main README.md file in the repository
  • Ensure file naming is consistent (board.json, board.png, readme.md)
  • Update index.ts file with new board
  • Update the package.json version ex: 1.7.0 -> 1.7.1 or 1.7.0 -> 1.8.0

Note: Once your changes have been merged, the owners of the insights app need to be notified

@ahadrovic ahadrovic requested a review from a team as a code owner October 24, 2023 16:34
@ahadrovic ahadrovic merged commit fb237c5 into main Oct 24, 2023
4 checks passed
@ahadrovic ahadrovic deleted the APP-13887 branch October 24, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordynBMcginnis JordynBMcginnis JordynBMcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahadrovic @JordynBMcginnis