Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing rrules. #78

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Add some missing rrules. #78

merged 3 commits into from
Aug 25, 2023

Conversation

leburgel
Copy link
Contributor

Fixed some typos in the tsvd rrule, and added rules for permute, scalar, TensorOperations.tensorcontract!, TensorOperations.tensoradd! and TensorOperations.tensortrace!.

@lkdvos
Copy link
Collaborator

lkdvos commented Aug 24, 2023

Can you rerun PEPSKit tests to check I didnt break anything?

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #78 (860c1d8) into ad (4693952) will decrease coverage by 0.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##               ad      #78      +/-   ##
==========================================
- Coverage   75.27%   74.32%   -0.95%     
==========================================
  Files          41       41              
  Lines        5322     5390      +68     
==========================================
  Hits         4006     4006              
- Misses       1316     1384      +68     
Files Changed Coverage Δ
ext/TensorKitChainRulesCoreExt.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lkdvos lkdvos merged commit 1eeabe2 into Jutho:ad Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants