Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing: Add namespace selection #176

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@caspermeijn
Copy link
Contributor

caspermeijn commented Jul 18, 2019

This adds the option to select the namespace used when sending
WS-Addressing messages. This is needed because the WS-Discovery spec
explicitly mentions the WS-Addressing 2004-08 namespace and some devices
will only respond to messages using that specific namespace.

Tested with kdsoap-ws-discovery-client and wsdd.

@dfaure-kdab

This comment has been minimized.

Copy link
Member

dfaure-kdab commented Aug 6, 2019

Looks good, but needs a rebase, can you do it?
Thanks.

This adds the option to select the namespace used when sending
WS-Addressing messages. This is needed because the WS-Discovery spec
explicitly mentions the WS-Addressing 2004-08 namespace and some devices
will only respond to messages using that specific namespace.
@caspermeijn caspermeijn force-pushed the caspermeijn:addressing_namespace branch from bf5bf97 to dc1b630 Aug 11, 2019
@caspermeijn

This comment has been minimized.

Copy link
Contributor Author

caspermeijn commented Aug 11, 2019

I assumed that your merge commit didn't include any changes. I just rebased my commit on the current master.

@dfaure-kdab

This comment has been minimized.

Copy link
Member

dfaure-kdab commented Aug 12, 2019

Right, that was a failed attempt at rebasing from the github GUI.

@dfaure-kdab dfaure-kdab merged commit 5371072 into KDAB:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.