-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select compatible KSP versions #1957
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
295ac5a
Introduced KspVersionCriteria, started to use it across the application
grzegrzk 0fa45cb
User can select compatible KSP versions - list is filtered & updated
grzegrzk cac3002
Redesigned dialog to choose compatible versions + it also displays ma…
grzegrzk a35bcd1
Reverted changes made in ChooseKspInstance - the "settings" button is…
grzegrzk e184753
Compatible versions are stored on disk + warning dialog is displayed …
grzegrzk 7d31e12
Corrected StrictGameComparator, corrected tests, removed unnecessary …
grzegrzk bb45796
Corrected reference to autofac + removed unnecessary code
grzegrzk 858a02c
Correction for tests
grzegrzk 4ea4e8a
Argh! Removed dependency added by accident when playing with nuget
grzegrzk d1a58c6
Naming changes to adhere to C# rules
grzegrzk 03176b4
KSP class now accepts only distinct compatible versions
grzegrzk 0763a89
Add IntersectWith method to KspVersionRange
dbent 4b13979
Merge remote-tracking branch 'upstream/feature/kspversionrange_inters…
grzegrzk c36ace0
Fix Highest/Lowest comparisons with unbounded bounds
dbent c52d721
Merge remote-tracking branch 'upstream/feature/kspversionrange_inters…
grzegrzk c40376d
StrictGameComparator is using now KspVersionRange.IntersectWith + add…
grzegrzk a28e013
Reverted Main.Designer.cs to last valid state
grzegrzk 17926c5
Added by hand menu item to Main.Designer.cs
grzegrzk 3aba61f
Got rid of compilation warnings
grzegrzk b8ac281
Got rid of compilation warnings in tests
grzegrzk bb29084
Added missing event handler to "Compatible KSP versions" menu item
grzegrzk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Text; | ||
|
||
namespace CKAN | ||
{ | ||
// | ||
//This is DTO object to be serialized/deserialized as JSON | ||
// | ||
class CompatibleKspVersionsDto | ||
{ | ||
public CompatibleKspVersionsDto() | ||
{ | ||
this.CompatibleKspVersions = new List<String>(); | ||
} | ||
|
||
public String VersionOfKspWhenWritten { get; set; } | ||
|
||
public List<String> CompatibleKspVersions { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
using CKAN.Versioning; | ||
using System.Collections.Generic; | ||
|
||
namespace CKAN.GameVersionProviders | ||
{ | ||
public interface IKspBuildMap | ||
{ | ||
KspVersion this[string buildId] { get; } | ||
|
||
List<KspVersion> KnownVersions { get; } | ||
|
||
void Refresh(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a sidenote we should really come up with a centralized mechanism to store both global and local settings data that is not the registry. But that's a story for another day.