Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbars to metadata tab #2759

Merged
merged 1 commit into from
May 10, 2019

Conversation

DasSkelett
Copy link
Member

Problem

The metadata is the only tab of the mod info panel that doesn't display scrollbars if its content is to big.
On low-res / small monitors or if you don't want to shrink your modlist / upper mod info panel some mod infos may be out of screen.

Solution

Make the tab scrollable, horizontally and vertically.
This also fixes the problem that links are mostly unreadable. Now they are all oneliners and if they are longer than the panel is wide, a scrollbar appears.

grafik

@DasSkelett DasSkelett added Pull request Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI and removed Pull request labels May 10, 2019
@HebaruSan
Copy link
Member

Code looks good and works well. I thought there was a consensus that horizontal scrolling is bad, but I was able to find few references to it other than this, and several contradicting it, so I guess that's fine, too:

https://www.nngroup.com/articles/scrolling-and-scrollbars/

@HebaruSan HebaruSan merged commit e0ce1fa into KSP-CKAN:master May 10, 2019
HebaruSan added a commit that referenced this pull request May 10, 2019
@Olympic1 Olympic1 removed Enhancement New features or functionality Pull request labels May 10, 2019
@DasSkelett
Copy link
Member Author

I thought there was a consensus that horizontal scrolling is bad

I think it's not optimal, but I don't see good alternatives here.
Line wrapping makes links rather unreadable in my opinion, at the latest when they are cut because they don't fit in the available horizontal space.
Also the way links are divided for the line breaking is catastrophic in most cases, something like

www.github.
com/KSP-CKAN/CKAN/pull/
2759

is not unusual.

And we already have a big area with horizontal scrolling > the modlist.

@DasSkelett DasSkelett deleted the feature/metadata-scrollbar branch May 10, 2019 16:59
@HebaruSan
Copy link
Member

Yeah, I gave up when I got to "users have to move their viewport in two dimensions, which makes it hard to cover the entire space" on that page. Covering the entire space is not a consideration. Users will see the labels and the start of the content, and in most cases they won't scroll at all.

@HebaruSan
Copy link
Member

1) Failed : Tests.Core.Net.Net.SpaceDockSSL
  Expected: No Exception to be thrown
  But was:  <System.Net.WebException: The request timed out
  at System.Net.WebClient.DownloadFile (System.Uri address, System.String fileName) [0x000ad] in <1a0168907d2042858c12ff7b2c118a26>:0 
  at System.Net.WebClient.DownloadFile (System.String address, System.String fileName) [0x00016] in <1a0168907d2042858c12ff7b2c118a26>:0 
  at (wrapper remoting-invoke-with-check) System.Net.WebClient.DownloadFile(string,string)
  at CKAN.Net.Download (System.String url, System.String& etag, System.String filename, CKAN.IUser user) [0x00192] in <6983702b63f744fdb5439a57982a2c26>:0 
  at CKAN.Net.Download (System.String url, System.String filename, CKAN.IUser user) [0x00001] in <6983702b63f744fdb5439a57982a2c26>:0 
  at Tests.Core.Net.Net+<>c.<SpaceDockSSL>b__5_0 () [0x00001] in <44c9297a81f343d385cefdb39bfdc841>:0 
  at NUnit.Framework.Constraints.ThrowsConstraint+VoidInvocationDescriptor.Invoke () [0x00000] in <64cd73ddfc8a470aa513c8243b429bdb>:0 
  at NUnit.Framework.Constraints.ThrowsConstraint+ExceptionInterceptor.Intercept (System.Object invocation) [0x00047] in <64cd73ddfc8a470aa513c8243b429bdb>:0 >
  at Tests.Core.Net.Net.SpaceDockSSL () [0x0000a] in <44c9297a81f343d385cefdb39bfdc841>:0 

https://forum.kerbalspaceprogram.com/index.php?/topic/184383-spacedock-isnt-working/

@DasSkelett
Copy link
Member Author

Our status page looks quite... disturbing right now.
BTW, what are all those

Error reading JArray from JsonReader. Current JsonReader item is not an array: StartObject. Path '', line 1, position 1.

errors that come and go for some time now @HebaruSan?
I tested some of those netkans and they run fine locally.

@HebaruSan
Copy link
Member

I have no idea. I tried the same thing with the same results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants