Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip comments and allow capital letters in locale extractor #2783

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

HebaruSan
Copy link
Member

Problems

Changes

  • Now we make sure that between the beginning of the line and the locale descriptor is only whitespace (since // isn't whitespace, comments are ignored)
  • Now we allow capital letters in locale strings
  • Now if the localizations property is already set, we don't parse anything and just move on to the next transformer

Fixes #2782.

@HebaruSan HebaruSan added Bug Something is not working as intended Pull request Netkan Issues affecting the netkan data labels Jun 13, 2019
@HebaruSan
Copy link
Member Author

I think we need this to fix the bot freezing as well. When I was testing with CommunityRealAgencyPack, the old code took a long time to process while the new finished quickly, and I observed the same with the bot via the status page.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot no obvious problems, and it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Minor parsing issues in locale extractor
2 participants