Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UK spelling of licence #2794

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Fix UK spelling of licence #2794

merged 1 commit into from
Jun 22, 2019

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jun 22, 2019 •
edited
Loading

Problem

CKAN uses the word "license" as a noun twice in the GUI:

image

image

Today I learned that this is a US-ism; in the UK and Australia, "license" is a verb and "licence" is a noun.

image
Noah Webster urges you to deal with it

Changes

Now the default spelling in our .resx files is changed to licence, and .en-US.resx files are added to override it to license in the en_US locale.

image

image

@HebaruSan HebaruSan added Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Jun 22, 2019
DasSkelett
DasSkelett approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English language is weird

@HebaruSan HebaruSan merged commit 9e8bf8c into KSP-CKAN:master Jun 22, 2019
HebaruSan added a commit that referenced this pull request Jun 22, 2019
@HebaruSan
Merge #2794 Fix UK spelling of licence
77a3bea
@HebaruSan HebaruSan deleted the fix/gui-license-licence branch June 22, 2019 22:02
@DasSkelett
Copy link
Member

Just got this quote after build ;)

Jenkins is refusing to work a simple fix and keeps reporting the
build as broken. 3 different people are trying to figure out why
NetKAN reports an error and calls a fourth one to come check it out.

"licence" is misspelled

-- Daz NetKAN#3159

@HebaruSan
Copy link
Member Author

Nice. @politas's comments on KSP-CKAN/NetKAN#3159 confirm that this convention was not made up by that web site but is in fact known to at least some speakers. 😁

@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HebaruSan @DasSkelett