Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for building with VS 2019 #2834

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Fix for building with VS 2019 #2834

merged 1 commit into from
Jul 21, 2019

Conversation

Olympic1
Copy link
Member

With the new release of Visual Studio 2019 it broke the ability to build the project with ToolsVersion="15.0" on Windows. This changes the building process to use Cake 0.34.1 so it can build again.

This change will print the following error on building:

The assembly 'Cake.SemVer, Version=3.0.0.0, Culture=neutral, PublicKeyToken=null'
is referencing an older version of Cake.Core (0.26.1).
For best compatibility it should target Cake.Core version 0.33.0.

Because the fix is released in 0.34.0, we need to ignore that warning.

@Olympic1 Olympic1 added Easy This is easy to fix Build Issues affecting the build system Windows Issues specific for Windows Cake Issues affecting Cake labels Jul 21, 2019
@Olympic1 Olympic1 merged commit 0518ea0 into KSP-CKAN:master Jul 21, 2019
Olympic1 added a commit that referenced this pull request Jul 21, 2019
@Olympic1
Merge #2834 Fix for building with VS 2019
7b00d47
@Olympic1 Olympic1 deleted the Build branch July 21, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Build Issues affecting the build system Cake Issues affecting Cake Easy This is easy to fix Windows Issues specific for Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olympic1 @DasSkelett