-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose game instance if default is locked #3382
Conversation
I tested it and it works for the most part, but I did ran into a problem: If I select a locked instance it just re-opens the selection dialog, in an ideal situation it would show the "Instance is locked" dialog at this point (but then still show the selection dialog again). If I then select the locked instance again (after the selector re-appears) the full GUI starts up and immediately throws an exception: RegisteryInUseKraken. If I select continue the GUI has no window title and it does not populate the mods list. |
This comment has been minimized.
This comment has been minimized.
9b6ab1d
to
2b58ab6
Compare
This comment has been minimized.
This comment has been minimized.
Okay I just tested the new version and it works properly in the startup case. However I did discover another issue that occurs when switching between instances (not opening a new one): The 'instance is locked' error not appearing on the correct screen did happen to me, but it does put that message on top so I saw it immediately, I don't think it's a big problem. |
2b58ab6
to
f762bd7
Compare
OK, now the GUI catches that exception, displays an error for it, and goes back to working with the original instance. There's a little delay because technically just the attempt to open the other instance invalidates certain things and we need to make sure everything is set up properly again. https://github.com/KSP-CKAN/CKAN/suites/2848264095/artifacts/63574915 |
634e067
to
52204c1
Compare
52204c1
to
b30653e
Compare
Just pushed the German translation, and also renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, should be good now. Nice enhancement, thanks for the suggestion @CodeLeopard!
Problem
If you have multiple game instances, you've selected one as the default instance, and you open that instance in CKAN, then opening another copy of CKAN will cause it to print an error about the instance being locked and quit.
However, if you have no default instance, then in the same flow you will be prompted to choose an instance. The user shouldn't lose options because they've selected a default instance.
Changes
Now if the default instance is locked by another process but there are other unlocked instances, the Manage Game Instances popup appears. Instances that have a
CKAN/registry.locked
file will have "(LOCKED)" appended to their names, so you can tell which ones are open in other instances of CKAN:Also the Linux man page's documentation for the
ckan ksp
subcommand is updated to the currentckan instance
naming.Fixes #3375.
@CodeLeopard, there should be a test build under the Checks tab shortly after this is submitted, if you wouldn't mind giving it a try.