Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu navigation take 2 #27

Merged
merged 8 commits into from
Dec 1, 2020
Merged

Menu navigation take 2 #27

merged 8 commits into from
Dec 1, 2020

Conversation

aspic
Copy link
Collaborator

@aspic aspic commented Nov 30, 2020

Continues the cleaning of menus removes a lot of unused views. This includes:

  1. Transactions are now a sub-menu of account
  2. When account has been selected, going into menu reflects that (send, receive, transactions of account)
  3. Extracted the "content" into it's own Content component, so that we can do things with the header later on

Menu states became a bit messy now (what to show depends on menu item (wallet, about etc), selected account and then account action. We should probably find a way to simplify this in the future.

@aspic aspic requested a review from Citrullin November 30, 2020 22:23
@Citrullin
Copy link
Contributor

From an UI perspective. I find the previous UI version I had more user friendly. I guess the user doesn't really care about the address. The amount on the wallet is more important. That is why the amount was large before and the name of the wallet small in a separator. We can also put the name at the secondary place. I would definitely place the amount of Nano in focus.

@Citrullin
Copy link
Contributor

Citrullin commented Nov 30, 2020

Also in the menu:
I wouldn't select main from send and receive.
Selecting the wallet after send or receive

Menu -> Send/Receive -> Select wallet -> QR Code/address
I like the small header with the number though. So that the user still sees the context where he currently is. It is a great improvement. Thanks! :)

Generate address doesn't make sense at the frontpage. I think that was my naming right? It should be generate wallet. Or add wallet, or something. ^^

The QR Code can fill most of the screen, no issue with that. Therfore the nano address can get removed. It is, on my phone, even not completely visible. Some of the last characters are not visible.

I really need to fix this scrolling. This is getting very annoying 🙈 :D

@Citrullin Citrullin mentioned this pull request Dec 1, 2020
8 tasks
@Citrullin Citrullin merged commit d9f93fb into master Dec 1, 2020
@aspic aspic deleted the menu-navigation-take-2 branch December 4, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants