Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore(deps): update dependency prettier to v3 #2103

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 6, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 2.8.8 -> 3.0.0 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.0.0

Compare Source

diff

🔗 Release Notes


Configuration

📅 Schedule: Branch creation - "before 6am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team July 6, 2023 00:39
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #2103 (cc3f8c7) into main (3867098) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2103   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files          89       89           
  Lines        2886     2886           
  Branches      667      667           
=======================================
  Hits         1938     1938           
  Misses        902      902           
  Partials       46       46           

@igarashitm
Copy link
Contributor

We have yarn format to run prettier
https://github.com/KaotoIO/kaoto-ui/pull/2103/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L24-L25

But IIRC we're not running it in GitHub workflows for PR check & main build. We should

  1. Run yarn format and fix all existing format errors
  2. Enable yarn format in GH workflow

Before we merge this.

@igarashitm igarashitm added the help wanted Extra attention is needed label Jul 6, 2023
@lordrip
Copy link
Member

lordrip commented Jul 7, 2023

We have yarn format to run prettier https://github.com/KaotoIO/kaoto-ui/pull/2103/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L24-L25

But IIRC we're not running it in GitHub workflows for PR check & main build. We should

1. Run `yarn format` and fix all existing format errors

2. Enable `yarn format` in GH workflow

Before we merge this.

Created #2110 for tackling this

@lordrip lordrip merged commit d8f2308 into main Jul 7, 2023
@lordrip lordrip deleted the renovate/prettier-3.x branch July 7, 2023 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants