-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Feature to import Docsets via the 'openInMenu' #52
Conversation
As far as I can tell this doesn't give any feedback to the user or open the Transfer Docset view? Is this correct? |
Yes, it only implements the possibility to copy a docset via the 'openIn' Menu to the transerPath. |
After some time, I was finally able to update the pull request. I now included a UIAlertController which gives feedback to the user after the docset was imported or an error occurred. |
Please clean up your code (e.g. indent it). |
Dash/DHAppDelegate.m
Outdated
@@ -115,10 +115,46 @@ - (BOOL)application:(UIApplication *)application openURL:(NSURL *)actualURL sour | |||
[[NSNotificationCenter defaultCenter] postNotificationName:DHPerformURLSearch object:[actualURL absoluteString]]; | |||
}); | |||
} | |||
else if([[actualURL pathExtension] caseInsensitiveCompare:@".docset"]) | |||
{ | |||
NSError *regexError; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not properly indented
Dash/DHAppDelegate.m
Outdated
@@ -115,10 +115,46 @@ - (BOOL)application:(UIApplication *)application openURL:(NSURL *)actualURL sour | |||
[[NSNotificationCenter defaultCenter] postNotificationName:DHPerformURLSearch object:[actualURL absoluteString]]; | |||
}); | |||
} | |||
else if([[actualURL pathExtension] caseInsensitiveCompare:@".docset"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not properly indented
Thank you! 👍 |
I added the feature to import Docsets via the 'openInMenu' in iOS.
Now it is possible to upload a .docset file to iCloud or any other CloudPlatform and import them directly on the iOS device into Dash.
This is especially suitable for use with the iOS11 Files App.
It is now also possible to import the Apple API Reference without iTunes File Sharing.