Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Feature to import Docsets via the 'openInMenu' #52

Merged
merged 7 commits into from
Oct 8, 2017
Merged

added Feature to import Docsets via the 'openInMenu' #52

merged 7 commits into from
Oct 8, 2017

Conversation

insightmind
Copy link
Contributor

I added the feature to import Docsets via the 'openInMenu' in iOS.

  • Now it is possible to upload a .docset file to iCloud or any other CloudPlatform and import them directly on the iOS device into Dash.
    This is especially suitable for use with the iOS11 Files App.

  • It is now also possible to import the Apple API Reference without iTunes File Sharing.

@Kapeli
Copy link
Owner

Kapeli commented Aug 9, 2017

As far as I can tell this doesn't give any feedback to the user or open the Transfer Docset view? Is this correct?

@insightmind
Copy link
Contributor Author

Yes, it only implements the possibility to copy a docset via the 'openIn' Menu to the transerPath.
The only pop-up-view that shows up, is the native copying pop-up-view in iOS11.
For user feedback, a change in the info-text of the TransferDocset-View or/and the automatic opening of the TransferDocset-View should be considered. I would improve my pull request if this feature is preferred.

@insightmind
Copy link
Contributor Author

After some time, I was finally able to update the pull request. I now included a UIAlertController which gives feedback to the user after the docset was imported or an error occurred.

@Kapeli
Copy link
Owner

Kapeli commented Oct 3, 2017

Please clean up your code (e.g. indent it).

@@ -115,10 +115,46 @@ - (BOOL)application:(UIApplication *)application openURL:(NSURL *)actualURL sour
[[NSNotificationCenter defaultCenter] postNotificationName:DHPerformURLSearch object:[actualURL absoluteString]];
});
}
else if([[actualURL pathExtension] caseInsensitiveCompare:@".docset"])
{
NSError *regexError;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not properly indented

@@ -115,10 +115,46 @@ - (BOOL)application:(UIApplication *)application openURL:(NSURL *)actualURL sour
[[NSNotificationCenter defaultCenter] postNotificationName:DHPerformURLSearch object:[actualURL absoluteString]];
});
}
else if([[actualURL pathExtension] caseInsensitiveCompare:@".docset"])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not properly indented

@insightmind
Copy link
Contributor Author

screen shot 2017-10-04 at 6 07 18 pm
Correctly indented in Xcode ... Strange

@Kapeli Kapeli merged commit 0d53be6 into Kapeli:master Oct 8, 2017
@Kapeli
Copy link
Owner

Kapeli commented Oct 8, 2017

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants