Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34803 - Display 0 package counts #10097

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

lfu
Copy link
Member

@lfu lfu commented May 9, 2022

What are the changes introduced in this pull request?

To display package count and icon even if the count is 0 on the content hosts table.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Hosts - Content Hosts

Expected
Screenshot from 2022-05-09 09-29-50
Screenshot from 2022-05-09 09-30-21

@theforeman-bot
Copy link

Issues: #34803

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Code looks good and works well on my system with centos7 and ubuntu 20.04. I was able to see the icons with rpm/deb based on the os type.

@lfu lfu merged commit b82bfb5 into Katello:master May 9, 2022
@lfu lfu deleted the pkg_count_0_34803 branch August 3, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants