Fixes #34992 - Use content ID to verify if a redhat_repo already exists #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using labels to verify if a red hat repository already exists create issues when labels differ between exporting and importing servers. Keep the validation to use labels as fallback for custom products, which doesn't keep the same content id between importing and exporting server and for the case where the export didn't include content_id
|
Can one of the admins verify this patch? |
|
Issues: #34992 |
|
ok to test |
|
[test katello] |
|
closing in favor of #10162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using labels to verify if a repository already exists create issues when labels differ between exporting and importing servers.
What are the changes introduced in this pull request?
Instead of using repository labels to verify if a repository being import already exists, this PR uses content ID.
What are the testing steps for this pull request?
Simulate a label mismatch between exporting and importing servers
Export content once and import it (this works fine)
Export content again (incremental export or a simple new complete export) and try importing again. Without this PR, the second import fails. With this patch it should work.
Opening this PR because #10139 was closed by mistake.