Fixes #35410 - Fix a pathing issue on exports #10223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34861 |
|
Looks like a VCR error was hit |
|
[test katello] |
1 similar comment
|
[test katello] |
parthaa
force-pushed
the
fix-paths
branch
2 times, most recently
from
50c8076
to
4ffaf7b
Compare
parthaa
changed the title
sjha4
reviewed
Aug 22, 2022
parthaa
force-pushed
the
fix-paths
branch
3 times, most recently
from
978347c
to
cc57a53
Compare
sjha4
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Change looks good and works as advertised.
Before change: /var/lib/pulp/exports/Default_Organization/An example content view/1.0/2022-08-23T15-08-26-00-00
After change: /var/lib/pulp/exports/Default_Organization/An_example_content_view/1.0/2022-08-23T15-07-33-00-00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
When exporting a content view version with a space its name we include that space in the generated path. Its not necessarily a bug but ideally we'd like path to be something like ->
/var/lib/pulp/exports/Test_Organization/Test_CV/1.0/2022-08-03T00-17-11-00-00/metadata.jsonvs
/var/lib/pulp/exports/Test_Organization/Test CV/1.0/2022-08-03T00-17-11-00-00/metadata.jsonThe cv name without and with space.
Considerations taken when implementing this change?
This issue was introduced when the previous syncable export work got merged and got caught on bats tests. So useful.
What are the testing steps for this pull request?
immediatedownload policyhammer content-export complete version --id=<cvv-id>Before this PR, you 'd see something like
/var/lib/pulp/exports/Test_Organization/Test CV/1.0/2022-08-03T00-17-11-00-00/metadata.jsonwith the spaceAfter this PR
/var/lib/pulp/exports/Test_Organization/Test_CV/1.0/2022-08-03T00-17-11-00-00/metadata.jsonwith the space