Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35693 - Use optimize and complete sync for APT repos #10258

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Fixes #35693 - Use optimize and complete sync for APT repos #10258

merged 1 commit into from
Dec 1, 2022

Conversation

quba42
Copy link
Contributor

@quba42 quba42 commented Aug 31, 2022 •
edited
Loading

What are the changes introduced in this pull request?

They allow for Katello to make use of the pulp_deb optimize sync mode, which uses exactly the same interface as the pulp_rpm optimize sync.

Considerations taken when implementing this change?

This requires pulp_deb 2.20.0 and pulpcore 3.21 as well as updated client rubygems. These versions will probably not be available in Katello for some time, so this PR is more for discussion for now.

What are the testing steps for this pull request?

There are three places where these changes can be used from:

  • smart proxy page > Synchronize (drop down) > Optimize Sync or Complete Sync
  • Repository page (of a deb type repo) > Select Action > Advanced Sync > Optimize Sync or Complete Sync > Sync
  • Products page > Select products that include deb type repos > Select Action > Advanced Sync > Optimize Sync or Complete Sync

In each case, the corresponding underlying pulp sync task needs to be called with the correctly set optimize flag.

@quba42 quba42 changed the title WIP: Use optimize and complete sync for APT repos Fixes #35693 - Use optimize and complete sync for APT repos Oct 31, 2022
@quba42 quba42 marked this pull request as ready for review October 31, 2022 07:01
@sjha4
Copy link
Member

sjha4 commented Nov 2, 2022

[test katello]

sjha4
sjha4 reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Even though this doesn't add the flag to smart proxy mirror repos, I'll hold off on merging this as this flag not being available in older pulp_deb gems. I am working on a patch to fix proxy syncs without the optimize flag.

@sjha4
Copy link
Member

sjha4 commented Dec 1, 2022

[test katello]

sjha4
sjha4 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ..Not expecting VCR failures on this because there are no changes to the tests but re-running suite just to make sure.

@sjha4 sjha4 merged commit a077047 into Katello:master Dec 1, 2022
@quba42 quba42 deleted the pulp_deb_optimize_sync branch December 6, 2022 13:19
chris1984 pushed a commit to chris1984/katello that referenced this pull request Dec 8, 2022
@quba42 @chris1984
Fixes #35693 - Use optimize and complete sync for APT repos (Katello#…
f815c40 
…10258)

https://projects.theforeman.org/issues/35693
(cherry picked from commit a077047)
chris1984 pushed a commit that referenced this pull request Dec 8, 2022
@quba42 @chris1984
Fixes #35693 - Use optimize and complete sync for APT repos (#10258)
aebb713 
https://projects.theforeman.org/issues/35693
(cherry picked from commit a077047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjha4 sjha4 sjha4 approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quba42 @sjha4 @theforeman-bot