Fixes #35810 - Use 'search' url param instead of 'host_ids' for job wizard #10371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #35810 |
|
Code looks sane, since it's just flipping url params, will start to test and ack based on that. |
chris1984
approved these changes
Dec 5, 2022
chris1984
added
Ready for merge
and removed
Not yet reviewed
Waiting on contributor
labels
chris1984
pushed a commit
to chris1984/katello
that referenced
this pull request
Dec 8, 2022
…izard (Katello#10371) (cherry picked from commit a06d647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Change the 'via customized remote execution' options in the new host details page to use the
searchurl param instead ofhost_ids. This will make them compatible with the new job wizard.Considerations taken when implementing this change?
What are the testing steps for this pull request?
Perform any customized REX action on the new host details page
ensure that the host search is filled in for you. (see the BZ https://bugzilla.redhat.com/show_bug.cgi?id=2149990 for more details)