Fixes #36328 - display short host name in Content Hosts page #10538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36328 |
lfu
force-pushed
the
append_domain_name_36328
branch
from
9732437
to
3ad03a4
Compare
lfu
force-pushed
the
append_domain_name_36328
branch
from
3ad03a4
to
30555a4
Compare
|
[test katello] |
Comment on lines
+56
to
+57
| <div data-block="modal-header" translate>Apply Errata to Content Host "{{host.displayname}}"?</div> | ||
| <div data-block="modal-body" translate>Are you sure you want to apply Errata to content host "{{ host.displayname }}"?</div> |
There was a problem hiding this comment.
@lfu Do you think this should be {{host.display_name}}?
Comment on lines
+42
to
+44
| <div data-block="modal-header" translate>Restart Services on Content Host "{{host.displayname}}"?</div> | ||
| <div data-block="modal-body"> | ||
| <span translate>Are you sure you want to restart services on content host "{{ host.name }}"?</span> | ||
| <span translate>Are you sure you want to restart services on content host "{{ host.displayname }}"?</span> |
This was referenced Feb 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Display host's FQDN or short name based on setting
display_fqdn_for_hostsinContent Hostspage.Considerations taken when implementing this change?
Depends on theforeman/foreman#9613
What are the testing steps for this pull request?
Make sure theforeman/foreman#9613 is available in your testing environment.
Verify the host name displayed in
Content Hostspage is based on settingdisplay_fqdn_for_hosts