Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37380 - Container push can fail with a different JSON error #10977

Merged

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Adds another error to catch that was found to have been raised on another machine when debug logging the push body.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Try pushing container content to Katello. To enable this, add

  :container_image_registry:
    :allow_push: true

to Katello's config file and ensure that your pulp-container has pulp/pulp_container#1589.

podman push 66640e9653de hostname/organization/product/arianna

I cannot reproduce this on another machine, so here's the old stack trace to go off of:

2024-04-22T18:02:13 [E|kat|deee32e7] Encoding::UndefinedConversionError: "\x8B" from ASCII-8BIT to UTF-8
...
 deee32e7 | /usr/share/gems/gems/katello-4.13.0.pre.master/app/lib/katello/http_resource.rb:89:in `issue_request'
 deee32e7 | /usr/share/gems/gems/katello-4.13.0.pre.master/app/lib/katello/resources/registry.rb:33:in `patch'
 deee32e7 | /usr/share/gems/gems/katello-4.13.0.pre.master/app/controllers/katello/api/registry/registry_proxies_controller.rb:248:in `upload_blob'
...
2024-04-22T18:02:13 [I|app|deee32e7] Completed 500 Internal Server Error in 116ms (Views: 0.2ms | ActiveRecord: 3.8ms | Allocations: 6849)

I did add this same fix to the reproducer machine and pushing worked right after.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, send it :shipit:

@ianballou ianballou merged commit 95a55e0 into Katello:master May 1, 2024
23 checks passed
@ianballou ianballou deleted the 37380-container-push-logger-issue-json branch May 1, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants