Fixes #37563 - Angular tests failing on master-source #11036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's needed to make those tests run on GHA too? |
|
Don't know how exactly to convert this to an action but the jenkins pipeline does this: |
|
Rebase and we shall see :) |
sjha4
force-pushed
the
fix_master_source_angular
branch
from
0893a39
to
4b8299f
Compare
|
Oooh..new tests.. 🎉 |
|
🍏 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Fixes angular tests failing on master following : 75d9c82
Considerations taken when implementing this change?
github CI seems to not be running our angular tests.
What are the testing steps for this pull request?
Check it out. Run bastion_katello tests locally by following steps in https://github.com/Katello/katello/blob/master/engines/bastion_katello/README.md#running-tests