Fixes #37560 - rewrite React GH action #11053
Conversation
jeremylenz
force-pushed
the
37560-react-tests-gh
branch
3 times, most recently
from
9d66994
to
d9cd342
Compare
jeremylenz
force-pushed
the
37560-react-tests-gh
branch
2 times, most recently
from
a3ce51d
to
bda2222
Compare
jeremylenz
force-pushed
the
37560-react-tests-gh
branch
from
bda2222
to
dd2889f
Compare
I'm not sure what's wrong here. |
There's probably a required check configured for this branch that now no longer exists. Some admin needs to fix that. |
| @@ -1,45 +1,23 @@ | |||
| name: React Tests (non-blocking) | |||
There was a problem hiding this comment.
This, albeit the name, used to be a required check in GH.
After the rename, it's not matching anymore, so you get the "waiting" job.
I don't think this needs to be a "required check", but if you want it to be, it needs to run on every PR, not limited to paths like below.
There was a problem hiding this comment.
Ahhh, I thought it was my rename of build to react-tests. That explains why changing it back to build didn't work.
@parthaa I would like to call this "React Tests" (without the "(non-blocking)"). Can you please make "React Tests" the required check and remove "React Tests (non-blocking)" ?
There was a problem hiding this comment.
@jeremylenz you probably need to merge this first before you can add it as a required check.
jeremylenz
force-pushed
the
37560-react-tests-gh
branch
from
dd2889f
to
3bc6e11
Compare
|
I had Partha remove the |
|
Looks like we might still have to merge this before the expected check is satisfied.. |
That's also my experience |
What are the changes introduced in this pull request?
Change the 'React Tests' GitHub action to use @theforeman/actions in line with Foreman CI.
This will also allow us to use
foreman_versionto test Katello PRs against any Foreman PR or branch.Considerations taken when implementing this change?
Also removed '(Non-blocking)' from the name, so it's assumed this is a blocking check. But I think we need a GH org admin to make that actually true.
What are the testing steps for this pull request?
critique my beautiful YAML
verify that CI passes and that the output reflects actual test runs