Fixes #37530 - Very long CV names/labels display weirdly on CV UI #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks fine, starting to test |
chris1984
reviewed
Jul 18, 2024
sjha4
force-pushed
the
truncate_cv_label
branch
2 times, most recently
from
248db46
to
c7b709a
Compare
chris1984
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds truncated name/labels to UI where necessary.
Considerations taken when implementing this change?
Truncate truncates by default to 50 chars which seems like enough information for a CV name. The full name is seen on the CV details tab.
What are the testing steps for this pull request?
Create a CV with a loooong name
Navigate around the CV UI and make sure the UI doesn't get weird with the long way and truncates and displays CV info properly.