Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - just to see travis output #1455

Closed
wants to merge 1 commit into from

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Jan 24, 2013

we are not good enough for rails 3.2

@lzap
Copy link
Contributor

lzap commented Jan 24, 2013

Mirek, fyi I will not accept this solution, please revert whole

#1418

as you are adding things like def rails32? which is totally unnecessary. Bundler_ext loads all system gems, it ignores versions. You do not need that. I did big Gemfiles cleanup the other day and it was working just fine.

If you must add a dependency for F18 that is missing in F17, we can add an environmental variable in the init.d script or something which you can check in the Gemfile, but keep in mind this must work also in bundler mode (development setup + travis). So far we have been using RUBY_VERSION for that because in F16 and F17 it was Ruby 1.8 vs Ruby 1.9. I think we need more generic solution.

OR

You can always create a bundler.d/fedora17 file with gems which are only for fedora17. The same for fedora18 or rhel6. And in the SPEC you can include/exclude those. We would need to make sure that these files will not be included when running in bundler mode. This is better approach I think.

@xsuchy
Copy link
Contributor Author

xsuchy commented Jan 24, 2013

rails32? is neccessary because of https://bugzilla.redhat.com/show_bug.cgi?id=901540 and we need compass-rails because of new compass, which landend not just to F18, but also to F17.

With this patch koji and travis pass, but "bundler install" fail with:

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    sass-rails (>= 0) ruby depends on
      railties (~> 3.1.0) ruby

    rails (= 3.0.10) ruby depends on
      railties (3.0.10)

Which I do not know how to resolve.

@lzap
Copy link
Contributor

lzap commented Jan 24, 2013

Mirku, I don't like this "if rails32? then" solution - I'd rather prefer an extra file in the bundler.d directory. But the more important thing is you too rushed with Fedora 18 upgrade in this case. Normally this would be fine, but with Rais 3.2 upgrade and it's new features you bite off more than you can chew I suspect.

Can you please revert all the changes you made to get Fedora 18 working? I'd expect Gemfile back to state with rails 3.0.x version. Thanks.

@xsuchy xsuchy closed this Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants