Initial Content Search merge #327
Conversation
Initial content search boilerplate
Content browser
CFB - Adding basic layouts for grid and browse box.
single select first environment linkage css change on select
this allows clicking on nodes to select the checkbox
Content browser select functionality
CFB - Adds basic browser elements for input and selection wireframing.
A couple of fixes to Content browser
Adding initial browse box functionality
(cherry picked from commit 889f1b5516b47afc47566647d8ea59f94581cc70)
Added product search + auto complete
adding product auto complete
up the environment selector to add/remove columns.
new column paradigm.
Added server side code for Repo Compare Shared/Unique
content browser - fixing migration of repo.library_instance_id
experience such that clicking to slide right reveals more columns to the right.
CS - Changes sliding aspect of grid to be more inuitive to a user's
content browser - fixing migration script to properly propogate paths
spec test fix
Content browser - merging in master
|
yes, we really need it to check functionality (as it seems done) right from master install. |
| before_filter :find_repos, :only => [:repo_compare_packages, :repo_compare_errata] | ||
|
|
||
| def rules | ||
| contents_test = lambda{true} |
There was a problem hiding this comment.
Will we have a permissions model for the content search?
There was a problem hiding this comment.
Ah good catch. There are no permissions directly related to content
search, it is based off visibility of Providers and Environments. So
we do need to fix that.
-Justin
On Tue, Jul 17, 2012 at 4:14 PM, Brad Buckingham
reply@reply.github.com
wrote:
+#
+# This software is licensed to you under the GNU General Public
+# License as published by the Free Software Foundation; either version
+# 2 of the License (GPLv2) or (at your option) any later version.
+# There is NO WARRANTY for this software, express or implied,
+# including the implied warranties of MERCHANTABILITY,
+# NON-INFRINGEMENT, or FITNESS FOR A PARTICULAR PURPOSE. You should
+# have received a copy of GPLv2 along with this software; if not, see
+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
+require 'util/package_util'
+class ContentSearchController < ApplicationController
- before_filter :find_repo, :only => [:repo_packages, :repo_errata]
- before_filter :find_repos, :only => [:repo_compare_packages, :repo_compare_errata]
- def rules
- contents_test = lambda{true}
Will we have a permissions model for the content search?
Reply to this email directly or view it on GitHub:
https://github.com/Katello/katello/pull/327/files#r1182571
|
Finished a very quick cursory pass through the code... In the future, would be nice to have features like this broken down in to smaller pull requests to make the review process more effective. I know, easier said than done... :) |
|
ACK |
|
ACK, with comments addressed in follow-up pull request. |
|
ACK from me. merge away |
Initial Content Search merge
QA requested a drop of content search so while this is not 100% complete, it is about 95% of the final content search feature.
@mccun934
@iNecas
@bbuckingham