761661 - Need inline help text #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forms cleanup by using custom katello form builder. Tipsy help can be added to each input with :help option. Rewritten _new forms: activation_keys cangesets environments filters gpg_keys organizations products providers systems users
| $('.details_container').addClass('scroll-pane'); | ||
| KT.common.jscroll_init($('.scroll-pane')); | ||
| }}); | ||
|
|
There was a problem hiding this comment.
I think this snippet would be better suited living in public/javascripts/wdigets/tipsy.custom.js
|
@Pajk I think this is a great addition and am glad you tackled it. My only other comment is in regards to the use of the single name variable to define the form in views. Granted, this may only be me, but I generally dislike single letter variables as they contain no context when reading the line by itself. Also, I found myself confusing where the 'f' stood for form or field when reading through the code and had to keep returning to the top to remind myself what it represented. |
|
This looks great to me. ACK. |
Default input size to 30. Help icon tag changed from span to i. Javascript moved to tispy.custom.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms cleanup by using custom katello form builder.
Advantages:
Tipsy help can be added to each input with :help option.
Now it looks like this http://d.pr/i/eCNT.
This pull request doesn't contain help texts yet, if anyone have an idea which inputs need additional help, write it down here please:
https://fedorahosted.org/katello/wiki/FormsInlineHelp
Rewritten _new forms:
activation_keys
cangesets
environments
filters
gpg_keys
organizations
products
providers
systems
users