-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build katello-headpin and katello-headpin-all from the same src.rpm as katello #412
Conversation
%{homedir}/lib/navigation | ||
%{homedir}/lib/notifications | ||
%{homedir}/lib/resources | ||
%exclude %{homedir}/lib/resources/candlepin.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you do not want to exclude this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nm, this is provided by another RPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just mimicked original spec, where was:
remove glue-specific files
rm -rf app/models/glue/*
rm lib/resources/candlepin.rb
rm lib/resources/pulp.rb
rm lib/resources/foreman.rb
i think this is the right approach. this will simplify our build system and we will be able to drop our headpin-build branch |
ACK! |
build katello-headpin and katello-headpin-all from the same src.rpm as katello
%exclude %{homedir}/lib/resources/pulp.rb | ||
%exclude %{homedir}/lib/resources/foreman.rb | ||
%{homedir}/lib/tasks | ||
%{homedir}/lib/util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirek please make sure this directory (lib/util) is accessible from BOTH katello and headpin. Installer uses it! You want to have this one in the katello-common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this directory is already in katello-common, which is required by katello-headpin. This would result in conflict. I will remove it from katello-headpin.
Nice work guys just make sure ^^^ @xsuchy |
No description provided.