Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7688: add a content hosts tab to the errata details. #4771

Merged
merged 1 commit into from
Dec 2, 2014
Merged

Fixes #7688: add a content hosts tab to the errata details. #4771

merged 1 commit into from
Dec 2, 2014

Conversation

waldenraines
Copy link
Contributor

Adds a content host tab to the errata details page that allows
the listing and syncing of applicable content hosts.

http://projects.theforeman.org/issues/7688

@jlsherrill
Copy link
Member

Chatted on irc a bit, but will write here:

  • We need an api to fetch the systems for each errata, as this will not fully scale.
  • We need to list both applicable and available systems (where you can only apply to available)
  • The search doesn't work, an api will make it work

@waldenraines waldenraines changed the title Fixes #7688: add a content hosts tab to the errata details. DO NOT MERGE: Fixes #7688: add a content hosts tab to the errata details. Oct 28, 2014
@waldenraines waldenraines changed the title DO NOT MERGE: Fixes #7688: add a content hosts tab to the errata details. Fixes #7688: add a content hosts tab to the errata details. Oct 30, 2014
@waldenraines
Copy link
Contributor Author

@jlsherrill updated.

@jlsherrill
Copy link
Member

Needs true 'select all' functionality.

@waldenraines
Copy link
Contributor Author

@jlsherrill updated to add true "select all" functionality and to display available/unavailable content hosts instead of available/applicable.

@waldenraines
Copy link
Contributor Author

Updated to remove distinction between available/unavailable.

waldenraines
waldenraines reviewed Nov 17, 2014
View reviewed changes
...pp/assets/javascripts/bastion_katello/errata/details/views/errata-details-content-hosts.html
<!--ng-click="applyErrata()">-->
<!--<i class="icon-signin leading-icon"></i>-->
<!--<span translate>Apply Errata</span>-->
<!--</button>-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out until we have the ability to show the confirmation page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we not have this ability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an API to show the versions (including point releases) that are about to change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh, what you really mean is 'commented out until we have incremental update' ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, pretty much. I can remove this entirely if you want and add it back afterwards.

jlsherrill
jlsherrill reviewed Nov 18, 2014
View reviewed changes
engines/bastion_katello/app/assets/javascripts/bastion_katello/errata/errata.routes.js
@@ -55,5 +55,13 @@ angular.module('Bastion.errata').config(['$stateProvider', function ($stateProvi
collapsed: true,
permission: 'view_errata',
templateUrl: 'errata/details/views/errata-details-info.html'
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space!

@waldenraines
Copy link
Contributor Author

@jlsherrill updated.

@jlsherrill
Copy link
Member

ACK

@waldenraines waldenraines reopened this Nov 21, 2014
@waldenraines
Copy link
Contributor Author

@jlsherrill had to rebase and had a merge conflict in erratum.factory.js because of the addition of autocomplete. Please make sure that looks okay and re-ACK if you don't mind.

@jlsherrill
Copy link
Member

ACK

Fixes Katello#7688: add content hosts tab to the errata details page.
858e542 
Adds a content host tab to the errata details page that allows
the listing and syncing of applicable content hosts.

http://projects.theforeman.org/issues/7688
@jlsherrill
Copy link
Member

ACK

waldenraines pushed a commit that referenced this pull request Dec 2, 2014
Merge pull request #4771 from waldenraines/7688
089d6ef 
Fixes #7688: add a content hosts tab to the errata details.
@waldenraines waldenraines merged commit 089d6ef into Katello:master Dec 2, 2014
@waldenraines waldenraines deleted the 7688 branch December 2, 2014 21:13
@waldenraines waldenraines restored the 7688 branch December 2, 2014 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs re-review Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waldenraines @jlsherrill @ehelms @theforeman-bot