some codestyle fixes, plus two errors #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0311: 40,0: Bad indentation. Found 9 spaces, expected 8
C0301:124,0: Line too long (131/120) C0301:154,0: Line too long (136/120) C0301:156,0: Line too long (128/120) C0301:203,0: Line too long (133/120) C0301:273,0: Line too long (134/120) C0301:306,0: Line too long (129/120) C0301:322,0: Line too long (131/120)
…space
except Exception,e:
^^
…rom outer scope (line 399)
R0201:240,4:ProgressBar.done: Method could be a function
R0201:147,4:List.format_tags: Method could be a function
C0301:299,0: Line too long (135/120)
C0301:376,0: Line too long (123/120)
…function call W0622:140,8:SystemGroupErrata.run: Redefining built-in 'type' E1123:145,17:SystemGroupErrata.run: Passing unexpected keyword argument 'type' in function call
W0613:307,41:UpdateContent.store_from_product: Unused argument 'opt_str' W0613:307,33:UpdateContent.store_from_product: Unused argument 'option' W0613:311,46:UpdateContent.store_item_with_product: Unused argument 'opt_str' W0613:317,33:UpdateContent.store_item: Unused argument 'opt_str' W0613:317,49:UpdateContent.store_item: Unused argument 'parse
method which is passed as argument can (under some cirumstances) use self and behave is method of instance
|
What are those errors? |
|
E1123: 88,17:List.run: Passing unexpected keyword argument 'type' in function call it is that error you reported on irc: |
|
Cool ACK |
lzap
added a commit
that referenced
this pull request
Aug 30, 2012
some codestyle fixes, plus two errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most important is:
E1123: 88,17:List.run: Passing unexpected keyword argument 'type' in function call
E1123: 88,17:List.run: Passing unexpected keyword argument 'type' in function call