Refs #11753 - remove elastic search from content view filter rules #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfouant
force-pushed
the
filter-rules-scoped-search
branch
3 times, most recently
from
3f49bfb
to
495457b
Compare
|
|
||
| @search_service.model = ContentViewFilter.rule_class_for(@filter) | ||
| respond(:collection => item_search(ContentViewFilter.rule_class_for(@filter), params, options)) | ||
| results = ContentViewFilter.rule_class_for(@filter) |
There was a problem hiding this comment.
It doesn't look like you're limiting filter rules to a specific filter? this would return all rules across the whole server wouldn't it?
There was a problem hiding this comment.
@jlsherrill - you're right, fixed
cfouant
force-pushed
the
filter-rules-scoped-search
branch
from
495457b
to
26cbfb4
Compare
|
ACK |
cfouant
added a commit
that referenced
this pull request
Nov 10, 2015
Refs #11753 - remove elastic search from content view filter rules
|
Did this commit not fix the issue in 11753? What else needs to be done? If it did fix it, please close it in Redmine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.