Fixes #5334 - removes traces of Elastic Search

[cfouant]

No description provided.

[beav]

There may still be a couple of traces in the backup/restore script and in the ping test.

LGTM aside from that though 🐨

[ehelms]

If this is designed to remove the last bits of ES, please update this to 'fixes' and also update the Redmine ticket to better describe what this is fixing.

[ehelms]

Looks like this is what @beav is referring to --https://github.com/Katello/katello/blob/master/spec/models/ping_spec.rb#L11-L12

Also, this can now be removed and any references to it (check application_controller.rb) -- https://github.com/Katello/katello/blob/master/config/katello.yaml.example#L16

This directory can be removed -- https://github.com/cfouant/katello/tree/166745889808a2279722209eee5d57b627894aaa/test/fixtures/vcr_cassettes/elasticsearch

[ehelms]

Blank line after this to separate logical chunks of code for readability.

[ehelms]

Parts of (or perhaps the entire file) can be removed -- https://github.com/cfouant/katello/blob/166745889808a2279722209eee5d57b627894aaa/spec/helpers/search_helper_methods.rb

[johnpmitsch]

Looks like here and here can be removed in host collections controller

[cfouant]

@johnpmitsch - should all traces of System.index be removed? I note at least one other.

[ehelms]

Can you also update the PR message to say fixes?

[johnpmitsch]

@cfouant I think so, I assume you mean https://github.com/Katello/katello/blob/master/lib/katello/tasks/clean_backend_objects.rake#L19 -- maybe @ehelms can confirm that line is ok to remove?

[ehelms]

@cfouant Yea, instances of System.index can be removed. In general, .index was an elasticsearch concept.

[ehelms]

Based on IRC conversation, you will want to remove the webmock removal commit -- that should also get the tests back to green.

[ehelms]

ACK for me -- as @jlsherrill did a lot of the original ES work, I'd like him to do final ACK on this

[jlsherrill]

ACK from me 👍 So long ES, we hardly knew ye 🚢

[mccun934]

I know this is closed but I wanted to comment with a 👍 and 👏