-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #15811 - product destroy - update error messages on failure #6208
Conversation
@bbuckingham for the case of:
I've heard the real complaint isn't necessarily the view, but which versions of the view. If the user has a bunch of versions they have to click through each one to figure it out. Could you enhance this to provide that information? |
@jlsherrill, I can. The bug description asked explicitly for content view names, but we can certainly include version info as well. Are you thinking something like : view1 version 1.0, 1.2, view2 version 2.0, 2.1, view 3 version 1.1 ? |
@bbuckingham right, I just recently had to right a custom rails console script for a user to tell them which versions to delete as they had probably 150 versions across many views (and like 5 versions had the repository in it). I think that wording is fine. |
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
@jlsherrill, Updated. The new format would look similar to the following:
|
Overall LGTM, i'll do a final test once rubocop is happy |
This commit provides more specific error messages when attempting to delete a product that is not allowed. Below are a couple of examples using the hammer-cli-katello: hammer> product delete --id 2 Could not destroy the product: Cannot delete product with repositories published in a content view. Product: zoo, Content Views: view1, view2, view3 hammer> product delete --id 51 Could not destroy the product: Cannot delete Red Hat product: Red Hat Enterprise Linux Server hammer> product delete --id 3 Product destroyed
Busted by rubocop.... Updated :) |
ACK |
This commit provides more specific error messages when
attempting to delete a product that is not allowed.
Below are a couple of examples using the hammer-cli-katello: