Fixes #16088 - Compatibility with Rails 4.2.7 #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a deprecation that caused tests to fail "Passing a nested array to Active Record finder methods is deprecated and will be removed. Flatten your array before using it for 'IN' conditions."
|
http://ci.theforeman.org/job/test_katello_core/19693 runs tests as Jenkins is waiting for a stable build - I merged the core patch too promptly and realized too late, sorry - it'd be safe to merge if that job passes |
| @@ -73,7 +73,7 @@ def test_update_from_json | |||
| errata = katello_errata(:security) | |||
| json = errata.attributes.merge('description' => 'an update', 'updated' => DateTime.now, 'reboot_suggested' => true) | |||
| errata.update_from_json(json) | |||
| errata = Erratum.find(errata) | |||
| errata = Erratum.find(errata.id) | |||
There was a problem hiding this comment.
I'm just curious about this change and why it was needed?
There was a problem hiding this comment.
A new deprecation apparently (not yet dropped in Rails), it's all over though
There was a problem hiding this comment.
Ah, thanks for the heads up.
|
ACK. Merging to get jenkins green. |
kgaikwad
pushed a commit
to kgaikwad/katello
that referenced
this pull request
Aug 30, 2016
Fixes a deprecation that caused tests to fail "Passing a nested array to Active Record finder methods is deprecated and will be removed. Flatten your array before using it for 'IN' conditions."
jlsherrill
pushed a commit
to jlsherrill/katello
that referenced
this pull request
Aug 31, 2016
Fixes a deprecation that caused tests to fail "Passing a nested array to Active Record finder methods is deprecated and will be removed. Flatten your array before using it for 'IN' conditions."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a deprecation that caused tests to fail
"Passing a nested array to Active Record finder methods is deprecated
and will be removed. Flatten your array before using it for 'IN'
conditions."