Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16484 - hostgroup - fix create params #6311

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

bbuckingham
Copy link
Member

Update to sync up the extensions params with foreman as well
as fix 'ActiveModel::ForbiddenAttributesError' error.

Update to sync up the extensions params with foreman as well
as update to fix 'ActiveModel::ForbiddenAttributesError' error.
@jlsherrill
Copy link
Member

[test]

@jlsherrill
Copy link
Member

we really need to add a way to add things rather than continuing this madness :)

@jlsherrill
Copy link
Member

ACK

@stbenjam
Copy link
Contributor

@bbuckingham Isn't this missing activation keys?

@bbuckingham
Copy link
Member Author

@stbenjam, there is some hidden magical logic that creates a group parameter to store the activation key associated with the hostgroup. I believe it is controlled by https://github.com/Katello/katello/blob/master/app/assets/javascripts/katello/hosts/activation_key_edit.js

@bbuckingham
Copy link
Member Author

@jlsherrill, agreed, it would be good to have a different solution for this down the road. This was primarily to quickly address a regression.

@stbenjam
Copy link
Contributor

Oh I see, for some reason I thought they were moved to attributes of the host group. Nevermind then, ACK

@bbuckingham
Copy link
Member Author

@stbenjam, @jlsherrill, Thanks!

@bbuckingham bbuckingham merged commit a2ed5e0 into Katello:master Sep 14, 2016
@bbuckingham bbuckingham deleted the issue-16484 branch September 14, 2016 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants