fixes #20863 - correctly extend smart proxies API #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #20863 |
houndci-bot
reviewed
Sep 8, 2017
| param :smart_proxy, Hash, :required => true, :action_aware => true do | ||
| param :name, String, :required => true | ||
| param :url, String, :required => true | ||
| update_api(:create, :update) do |
|
@bbuckingham, it might be worth of bumping apipie-rails dep to 0.5.4, see theforeman/foreman-packaging#1800 for details. #6937 added 0.5.2 since that was the version that introduced the feature but there were 2 fixes added after it was merged. |
|
Thanks @ares! Updated! |
|
LGTM 👍 (not tested) |
|
Thanks @ares and @jlsherrill ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to mimic the awesome work done by @ares with #6937. @ares++