Fixes #23873 - Cannot remove content view on org destroy #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #23873 |
jlsherrill
reviewed
Jun 11, 2018
| @@ -67,7 +67,7 @@ def plan(content_view, options) | |||
|
|
|||
| if organization_destroy | |||
| content_view.hostgroups.clear | |||
There was a problem hiding this comment.
This should likely be destroy_all as well
There was a problem hiding this comment.
I'm not against changing it but I think my test illustrates that at least for now w/ the way the associations are set up, we don't need it. That said, will update!
There was a problem hiding this comment.
I think we would have run into a problem if something else referenced the hostgroup that would have been 'deleted'. Such as another hostgroup or another host that hadn't been deleted yet
jturel
force-pushed
the
content_view_remove_action
branch
from
e30b33d
to
a216843
Compare
jlsherrill
approved these changes
Jun 11, 2018
|
@jlsherrill you OK with a merge here despite the react failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nightly build