Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test for invalid cron expression #7692

Merged
merged 1 commit into from
Sep 11, 2018
Merged

added test for invalid cron expression #7692

merged 1 commit into from
Sep 11, 2018

Conversation

omkarkhatavkar
Copy link
Contributor

Added test for invalid cron expression

Run options: --name=test_invalid_custom_cron_expression --seed 5536

# Running:

.

Finished in 0.777028s, 1.2870 runs/s, 2.5739 assertions/s.
1 runs, 2 assertions, 0 failures, 0 errors, 0 skips
Coverage report Rcov style generated for Unit Tests to /home/vagrant/foreman/coverage/rcov
Coverage report generated for Unit Tests to /home/vagrant/foreman/coverage. 0.0 / 0.0 LOC (100.0%) covered.

@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 04885c3 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@sjha4
Copy link
Member

sjha4 commented Sep 11, 2018

@omkarkhatavkar : 👍 for adding more tests around this.

APJ!

@omkarkhatavkar omkarkhatavkar force-pushed the test_invalid_custom_cron_expression branch from 04885c3 to ab8c42b Compare September 11, 2018 11:55
@sjha4
Copy link
Member

sjha4 commented Sep 11, 2018

[test katello]

sjha4
sjha4 approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK..Thanks @omkarkhatavkar !

@sjha4 sjha4 merged commit 227fd40 into Katello:master Sep 11, 2018
@omkarkhatavkar omkarkhatavkar deleted the test_invalid_custom_cron_expression branch September 12, 2018 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjha4 sjha4 sjha4 approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omkarkhatavkar @theforeman-bot @sjha4