Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24587 - Modules Streams associated to a CVV #7699

Closed
wants to merge 3 commits into from

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Sep 12, 2018

UI bindings to show module streams associated to a content view version
Piggy backs off #7698 and #7688

Look at the last commit for the changes here
cvv

John Mitsch and others added 3 commits September 10, 2018 19:43
Adds the ability to view repository Module Streams
Added code to show module streams in a repository
UI bindings to show module stream data for a content view version
@theforeman-bot
Copy link

Issues: #24587

</tr>
</tbody>
</table>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the same as the other PR, you can make this a shared template/partial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@parthaa parthaa changed the title [WIP] Fixes #24587 - Modules Streams associated to a CVV Fixes #24587 - Modules Streams associated to a CVV Sep 12, 2018
scoped_search on: :context, complete_value: true
scoped_search on: :arch, complete_value: true
scoped_search relation: :repositories, on: :name, rename: :repository, complete_value: true
scoped_search relation: :repositories, on: :id, rename: :repository_id, complete_value: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does repo id really need to be searchable?

@parthaa
Copy link
Contributor Author

parthaa commented Sep 13, 2018

Closing this .. Comments here are going to be addressed in #7698

@parthaa parthaa closed this Sep 13, 2018
@parthaa parthaa deleted the cvv branch November 3, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants