Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25410 - fix env update with docker repositories #7819

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

jlsherrill
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #25410

@mirekdlugosz
Copy link
Member

Checked PR on top of b320ee9 - looks good. There is no error message when I modify Registry Name Pattern for Library environment.

@beav
Copy link
Contributor

beav commented Nov 14, 2018

@jlsherrill I'm not sure what the difference is between Update and InstanceUpdate. When should the latter be used?

@jlsherrill
Copy link
Member Author

@beav ::Update is really meant for update the Root Repository, while InstanceUpdate was meant for updating the repository instance. We might should refactor the actions such that its using RootRepository::Update vs Repository::Update, but i was trying to keep this bugfix small.

@beav
Copy link
Contributor

beav commented Nov 14, 2018

@jlsherrill that makes sense. I agree that changing everything to RootRepository::Update would be a big change for this PR. Can you put in a redmine for it?

code looks good and was tested in #7819 (comment), so ack otherwise

@jlsherrill
Copy link
Member Author

@beav beav merged commit cff302e into Katello:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants