Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26166 - move metadata generate to service class #7987

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Fixes #26166 - move metadata generate to service class #7987

merged 2 commits into from
Mar 12, 2019

Conversation

jlsherrill
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #26166

@johnpmitsch johnpmitsch self-requested a review March 1, 2019 20:50
@jlsherrill
Copy link
Member Author

Places we generate metadata:

  1. repo creation
  2. Manual generation for a single repository
  3. Manual generation for a content view version
  4. Content View publish
  5. Content View Promote
  6. Complete Smart Proxy Sync

@johnpmitsch johnpmitsch self-assigned this Mar 4, 2019
@johnpmitsch
Copy link
Contributor

Things are working well! One weird thing I am seeing is Published (Invalid Date) under Status for CVV, I don't think its related to the PR since I see it on master, but figured I would bring it up in case it is related to pulp3 changes.

@johnpmitsch
Copy link
Contributor

Unfortunately, I can't properly test capsules. I am seeing this error on both your branch and master when syncing:



Actions::Pulp::Consumer::SyncCapsule

Input:

{"capsule_id"=>2,
 "repo_pulp_id"=>"2-cv1-Library-puppet-79f124ab-7d5f-45e5-8d4f-53c13a4a8ab4",
 "sync_options"=>{"remove_missing"=>true},
 "remote_user"=>"admin",
 "remote_cp_user"=>"admin",
 "locale"=>"en",
 "current_request_id"=>"c90a7291-4dd1-42a9-b682-dd1808f40c09",
 "current_timezone"=>"America/New_York",
 "current_user_id"=>4,
 "current_organization_id"=>nil,
 "current_location_id"=>nil}

Output:

{"pulp_tasks"=>
  [{"exception"=>nil,
    "task_type"=>"pulp.server.managers.repo.sync.sync",
    "_href"=>"/pulp/api/v2/tasks/d6760c81-1fe8-4a64-8cfe-5784038f8f39/",
    "task_id"=>"d6760c81-1fe8-4a64-8cfe-5784038f8f39",
    "tags"=>
     ["pulp:repository:2-cv1-Library-puppet-79f124ab-7d5f-45e5-8d4f-53c13a4a8ab4",
      "pulp:action:sync"],
    "finish_time"=>"2019-03-12T01:15:04Z",
    "_ns"=>"task_status",
    "start_time"=>"2019-03-12T01:15:02Z",
    "traceback"=>
     "Traceback (most recent call last):\n" +
     "  File \"/usr/lib/python2.7/site-packages/celery/app/trace.py\", line 367, in trace_task\n" +
     "    R = retval = fun(*args, **kwargs)\n" +
     "  File \"/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py\", line 529, in __call__\n" +
     "    return super(Task, self).__call__(*args, **kwargs)\n" +
     "  File \"/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py\", line 107, in __call__\n" +
     "    return super(PulpTask, self).__call__(*args, **kwargs)\n" +
     "  File \"/usr/lib/python2.7/site-packages/celery/app/trace.py\", line 622, in __protected_call__\n" +
     "    return self.run(*args, **kwargs)\n" +
     "  File \"/usr/lib/python2.7/site-packages/pulp/server/controllers/repository.py\", line 828, in sync\n" +
     "    raise pulp_exceptions.PulpExecutionException(_('Importer indicated a failed response'))\n" +
     "PulpExecutionException: Importer indicated a failed response\n",
    "spawned_tasks"=>[],
    "progress_report"=>
     {"puppet_importer"=>
       {"modules"=>
         {"error_message"=>nil,
          "execution_time"=>nil,
          "total_count"=>nil,
          "traceback"=>nil,
          "individual_errors"=>[],
          "state"=>"not-started",
          "error_count"=>nil,
          "error"=>"None",
          "finished_count"=>nil},
        "metadata"=>
         {"query_finished_count"=>0,
          "traceback"=>
           [["/usr/lib/python2.7/site-packages/pulp_puppet/plugins/importers/forge.py",
             115,
             "_parse_metadata",
             "metadata_json_docs = downloader.retrieve_metadata(self.progress_report)"],
            ["/usr/lib/python2.7/site-packages/pulp_puppet/plugins/importers/downloaders/web.py",
             57,
             "retrieve_metadata",
             "raise exceptions.FileRetrievalException(report.error_msg)"]],
          "execution_time"=>1,
          "query_total_count"=>1,
          "error_message"=>"Error downloading metadata",
          "state"=>"failed",
          "error"=>"FileRetrievalException: Not Found",
          "current_query"=>
           "https://centos7-devel-scl.jomitsch.example.com/pulp/puppet/2-cv1-Library-puppet-79f124ab-7d5f-45e5-8d4f-53c13a4a8ab4/modules.json"}}},
    "queue"=>
     "reserved_resource_worker-1@centos7-proxy-devel-scl.jomitsch.example.com.dq2",
    "state"=>"error",
    "worker_name"=>
     "reserved_resource_worker-1@centos7-proxy-devel-scl.jomitsch.example.com",
    "result"=>nil,
    "error"=>
     {"code"=>"PLP0000",
      "data"=>{},
      "description"=>"Importer indicated a failed response",
      "sub_errors"=>[]},
    "_id"=>{"$oid"=>"5c87081644a47307d6a96f9c"},
    "id"=>"5c87081644a47307d6a96f9c"}],
 "poll_attempts"=>{"total"=>4, "failed"=>1}}

Exception:

Katello::Errors::PulpError: PLP0000: Importer indicated a failed response

Backtrace:

/home/vagrant/katello/app/lib/actions/pulp/abstract_async_task.rb:122:in `block in external_task='
/home/vagrant/katello/app/lib/actions/pulp/abstract_async_task.rb:120:in `each'
/home/vagrant/katello/app/lib/actions/pulp/abstract_async_task.rb:120:in `external_task='
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action/polling.rb:98:in `poll_external_task_with_rescue'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action/polling.rb:21:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action/cancellable.rb:13:in `run'
/home/vagrant/katello/app/lib/actions/pulp/abstract_async_task.rb:45:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:538:in `block (3 levels) in execute_run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:31:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/katello/app/lib/actions/middleware/remote_action.rb:16:in `block in run'
/home/vagrant/katello/app/lib/actions/middleware/remote_action.rb:40:in `block in as_remote_user'
/home/vagrant/katello/app/models/katello/concerns/user_extensions.rb:21:in `cp_config'
/home/vagrant/katello/app/lib/actions/middleware/remote_action.rb:27:in `as_cp_user'
/home/vagrant/katello/app/lib/actions/middleware/remote_action.rb:39:in `as_remote_user'
/home/vagrant/katello/app/lib/actions/middleware/remote_action.rb:16:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/rails_executor_wrap.rb:14:in `block in run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/activesupport-5.2.1/lib/active_support/execution_wrapper.rb:87:in `wrap'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/rails_executor_wrap.rb:13:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action/progress.rb:30:in `with_progress_calculation'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action/progress.rb:16:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/katello/app/lib/actions/middleware/keep_locale.rb:11:in `block in run'
/home/vagrant/katello/app/lib/actions/middleware/keep_locale.rb:22:in `with_locale'
/home/vagrant/katello/app/lib/actions/middleware/keep_locale.rb:11:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_request_id.rb:15:in `block in run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_request_id.rb:49:in `restore_current_request_id'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_request_id.rb:15:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_timezone.rb:15:in `block in run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_timezone.rb:44:in `restore_curent_timezone'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_timezone.rb:15:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_user.rb:15:in `block in run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_user.rb:43:in `restore_curent_user'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_user.rb:15:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_taxonomies.rb:15:in `block in run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_taxonomies.rb:44:in `restore_current_taxonomies'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/foreman-tasks-0.15.0/app/lib/actions/middleware/keep_current_taxonomies.rb:15:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:26:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:18:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware.rb:31:in `run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/stack.rb:22:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/middleware/world.rb:30:in `execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:537:in `block (2 levels) in execute_run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:536:in `catch'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:536:in `block in execute_run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:450:in `block in with_error_handling'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:450:in `catch'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:450:in `with_error_handling'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:531:in `execute_run'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/action.rb:277:in `execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/execution_plan/steps/abstract_flow_step.rb:17:in `block (2 levels) in execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/execution_plan/steps/abstract.rb:162:in `with_meta_calculation'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/execution_plan/steps/abstract_flow_step.rb:16:in `block in execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/execution_plan/steps/abstract_flow_step.rb:30:in `open_action'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/execution_plan/steps/abstract_flow_step.rb:15:in `execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/director.rb:56:in `execute'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/executors/parallel/worker.rb:14:in `block in on_message'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/executors.rb:12:in `run_user_code'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/executors/parallel/worker.rb:13:in `on_message'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/context.rb:46:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/executes_context.rb:7:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/dynflow-1.2.2/lib/dynflow/actor.rb:26:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/awaits.rb:15:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/sets_results.rb:14:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/buffer.rb:38:in `process_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/buffer.rb:31:in `process_envelopes?'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/buffer.rb:20:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/termination.rb:55:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/removes_child.rb:10:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/abstract.rb:25:in `pass'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/behaviour/sets_results.rb:14:in `on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/core.rb:162:in `process_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/core.rb:96:in `block in on_envelope'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/core.rb:119:in `block (2 levels) in schedule_execution'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/synchronization/mutex_lockable_object.rb:41:in `block in synchronize'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/synchronization/mutex_lockable_object.rb:41:in `synchronize'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/synchronization/mutex_lockable_object.rb:41:in `synchronize'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-edge-0.4.1/lib-edge/concurrent/actor/core.rb:116:in `block in schedule_execution'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/serialized_execution.rb:18:in `call'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/serialized_execution.rb:96:in `work'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/serialized_execution.rb:77:in `block in call_job'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:348:in `run_task'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:337:in `block (3 levels) in create_worker'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `loop'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `block (2 levels) in create_worker'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:319:in `catch'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/concurrent-ruby-1.1.4/lib/concurrent/executor/ruby_thread_pool_executor.rb:319:in `block in create_worker'
/home/vagrant/foreman/.vendor/ruby/2.5.0/gems/logging-2.2.2/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'

johnpmitsch
johnpmitsch approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@johnpmitsch johnpmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good and it performed well for each content type during basic actions. I'll look into the capsule sync issue more and file something.

Nice changes! 👍

@jlsherrill jlsherrill merged commit 9f90895 into Katello:master Mar 12, 2019
@jlsherrill jlsherrill deleted the 26166 branch March 12, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpmitsch johnpmitsch johnpmitsch approved these changes

Assignees

@johnpmitsch johnpmitsch

Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlsherrill @theforeman-bot @johnpmitsch