Fixes #31122 - use new react_component mounter #8996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #31122 |
|
ping... we should get this in for the next release :) |
|
Added to our board so someone should be reviewing soon! |
jeremylenz
reviewed
Nov 20, 2020
| <div id="reactRoot"></div> | ||
| <%= mount_react_component('katello', '#reactRoot') %> | ||
| <div id="reactRoot"> | ||
| <%= react_component('katello') %> |
There was a problem hiding this comment.
Now that theforeman/foreman#8033 is merged, should these be foreman_react_component?
There was a problem hiding this comment.
update: nevermind, I realized that it's just the web component that was renamed, not the ruby method :)
jeremylenz
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Thanks @ezr-ondrej
Tested loading Katello and also the TypeAheadSelect on the host groups / Activation Keys edit page, all working fine. ACK 👍
jturel
pushed a commit
to jturel/katello
that referenced
this pull request
Dec 9, 2020
(cherry picked from commit faf2323)
jturel
pushed a commit
that referenced
this pull request
Dec 10, 2020
(cherry picked from commit faf2323)
ranjan
pushed a commit
to ranjan/katello
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.