Upgrade to Cosmos v0.46 #1477
Merged
Upgrade to Cosmos v0.46 #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Signed-off-by: drklee3 <derrick@dlee.dev>
Causes failed to load state at height errors
pirtleshell
reviewed
Mar 21, 2023
* add store tests for Borrow type * refactor Deposit tests to match
|
On the |
rhuairahrighairidh
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
had a final look through, found a couple of small things I added to #1522 , but otherwise looks good for internal testnet 🚀
Comment on lines
+210
to
+214
|
|
||
| if rp.RewardsPerSecond.Amount.IsZero() { | ||
| return fmt.Errorf("reward amount cannot be zero: %v", rp.RewardsPerSecond) | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: what was the reason for this change?
There was a problem hiding this comment.
It is passed to sdk.NewDecCoinsFromCoins in the accumulator which would have the sdk bug in the method if it has a 0 amount
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version upgrades:
Note that Cosmos and Ethermint forked dependencies use a pseudo-version targeting the latest commits on the branches, and should be updated to use a tagged version when review of those dependecies are completed.